View Issue Details

WikiJump to Notes
IDProjectCategoryView StatusDate SubmittedLast Update
0026590mantisbtinstallationpublic2020-01-10 13:442020-02-24 16:45
Reporterrogueresearch Assigned To 
PrioritynormalSeverityminorReproducibilityalways
Status newResolutionopen 
Product Version2.21.1 
Summary0026590: Wording of admin/check/index.php results could be clarified with a prefix
Description

When I run admin/check/index.php I get the attached results.

mysql.allow_local_infile php.ini directive is set to 0
mysql.allow_local_infile should be disabled to prevent remote attachers to access local files (see issue #23173).

Database default collation is UTF-8
Database is using latin1_swedish_ci collation where UTF-8 collation is required.

Maybe it's just me, but in both cases, the wording of the first line does not make it clear if it's:

  • stating the problem found, or
  • stating the expectation

I think this would be much clearer with a little prefix, like:

Checking if: mysql.allow_local_infile php.ini directive is set to 0
mysql.allow_local_infile should be disabled to prevent remote attachers to access local files (see issue #23173).

Checking if: Database default collation is UTF-8
Database is using latin1_swedish_ci collation where UTF-8 collation is required.
TagsNo tags attached.
Attached Files
MantisChecks.png (77,494 bytes)   
MantisChecks.png (77,494 bytes)   

Relationships

has duplicate 0026735 closedatrol Misleading wording for warning "register_argc_argv" in Check script 

Activities

dregad

dregad

2020-01-10 18:06

developer   ~0063421

The check's description is always stating the expectation (or at least it should be, I did not go back and check every single test).

I hear your argument, but I'm not sure I is really worth the effort to update the all the individual checks' descriptions... And I'm not sure that updating the function printing the test row would be the correct approach, as there are probably a few cases where Checking if or whatever prefix we pick, would not be applicable.
rogueresearch

rogueresearch

2020-01-10 18:37

reporter   ~0063422

Thanks for the confirmation that it's stating the expectation.

I did come to that conclusion eventually, but for quite a while I thought this was showing me a list of errors, not a list of (failed) expectations. i.e. I thought it was telling me that mysql.allow_local_infile is set to 0 and that I should therefore change it to 1.

I don't know the codebase, but perhaps there is a way to add the prefix without changing every individual check's description...?
dregad

dregad

2020-01-11 17:09

developer   ~0063426

I don't know the codebase, but perhaps there is a way to add the prefix without changing every individual check's description...?

That's basically what I meant with _I'm not sure that updating the function printing the test row would be the correct approach, as there are probably a few cases where Checking if or whatever prefix we pick, would not be applicable._

In clear, there are functions that perform the check and print the results, check_print_test_row() and check_print_test_warn_row() so changing those would only work if ALL checks are written the same way.