|
|
Set project sometimes remembers what page you came from (set_project.php) but it's hardcoded to a few pages. There's also support for passing f_ref into the page to be used for redirection (apparently some proxies clear the HTTP_REFERRER).
We definitely need to make this work better. My question is, why can't we always redirect directly to the full referrer URL? (maybe assuming it's within our domain at least) |
|
|
Here is the proposed patch. Comments from other developers welcome.
diff -u -r1.52 set_project.php
--- set_project.php 14 Feb 2005 10:21:44 -0000 1.52
+++ set_project.php 22 Apr 2005 00:29:16 -0000
@@ -36,11 +36,6 @@
helper_set_current_project( $f_project_id );
- #@@@ we really need to make this more general... it is never intuitive
-
to redirect to the main page as far as I can see. Is there a reason
-
we can't just redirect back to the referrer in all cases? See
-
issue 0002686 about this... -jf
-
# redirect to 'same page' when switching projects.
# view_all_* pages, and summary
# for proxies that clear out HTTP_REFERER
@@ -48,42 +43,34 @@
$t_redirect_url = $f_ref;
} else if ( !isset( $_SERVER['HTTP_REFERER'] ) || is_blank( $_SERVER['HTTP_REFERER'] ) ) {
$t_redirect_url = config_get( 'default_home_page' );
- } else if ( eregi( 'view_all_bug_page.php', $_SERVER['HTTP_REFERER'] ) ){
- $t_source_filter_id = filter_db_get_project_current( $f_project_id );
- $t_redirect_url = 'view_all_set.php?type=4';
-
- if ( $t_source_filter_id != null ) {
- $t_redirect_url = 'view_all_set.php?type=3&source_query_id=' . $t_source_filter_id;
- }
- } else if ( eregi( 'changelog_page.php', $_SERVER['HTTP_REFERER'] ) ){
- $t_redirect_url = 'changelog_page.php';
- } else if ( eregi( 'summary_page.php', $_SERVER['HTTP_REFERER'] ) ){
- $t_redirect_url = 'summary_page.php';
- } else if ( eregi( 'proj_user_menu_page.php', $_SERVER['HTTP_REFERER'] ) ){
- $t_redirect_url = 'proj_user_menu_page.php';
- } else if ( eregi( 'manage_user_page.php', $_SERVER['HTTP_REFERER'] ) ){
- $t_redirect_url = 'manage_user_page.php';
- } else if ( eregi( 'bug_report_page.php', $_SERVER['HTTP_REFERER'] ) ){
- $t_redirect_url = 'bug_report_page.php';
- } else if ( eregi( 'bug_report_advanced_page.php', $_SERVER['HTTP_REFERER'] ) ){
- $t_redirect_url = 'bug_report_advanced_page.php';
- } else if ( eregi( 'summary_jpgraph_page.php', $_SERVER['HTTP_REFERER'] ) ){
- $t_redirect_url = 'summary_jpgraph_page.php';
- } else if ( eregi( 'view_filters_page.php', $_SERVER['HTTP_REFERER'] ) ){
- $t_redirect_url = 'view_filters_page.php';
- } else if ( eregi( 'my_view_page.php', $_SERVER['HTTP_REFERER'] ) ){
- $t_redirect_url = 'my_view_page.php';
- } else if ( eregi( 'main_page.php', $_SERVER['HTTP_REFERER'] ) ){
- $t_redirect_url = 'main_page.php';
} else {
- $t_redirect_url = config_get( 'default_home_page' );
-
Check that referrer matches our address
- $t_path = config_get( 'path' );
- if ( $t_path == substr( $_SERVER['HTTP_REFERER'], 0, strlen( $t_path ) ) ) {
-
if view_all_bug_page, pass on filter
- if ( eregi( 'view_all_bug_page.php', $_SERVER['HTTP_REFERER'] ) ){
- $t_source_filter_id = filter_db_get_project_current( $f_project_id );
- $t_redirect_url = 'view_all_set.php?type=4';
-
- if ( $t_source_filter_id != null ) {
- $t_redirect_url = 'view_all_set.php?type=3&source_query_id=' . $t_source_filter_id;
- }
- } else if ( eregi( '_page.php', $_SERVER['HTTP_REFERER'] ) ){
-
if any other page, return to that page
- $t_redirect_url = substr( $_SERVER['HTTP_REFERER'], strlen( $t_path ) );
- } else {
- $t_redirect_url = config_get( 'default_home_page' );
- }
- } else {
- $t_redirect_url = config_get( 'default_home_page' );
- }
}
|
|
|
Review comments from IRC chat:
<Victor> $t_path == substr( $_SERVER['HTTP_REFERER'], 0, strlen( $t_path ) )
<Victor> what about case sensitivity?
<Victor> what about if one ends with / and the other doesn't
<Victor> eregi( 'view_all_bug_page.php', $_SERVER['HTTP_REFERER'] )
<Victor> shouldn't we look for $g_path + 'view_all_bugs_page.php'?
<thraxisp> doesn't $g_path always have to end in a /?
<thraxisp> The check is only done if the beginning only matches $g_path. I should only check the training page part anyways.
<Victor> yes, but does the referrer always end with /?
<Victor> get default home page once and store it in a variable ($t_default_home_page).
<thraxisp> referrer should always be a full file name.
<Victor> ok.
<Victor> the logic of the change looks fine.
<Victor> I am not very familiar with the filters part.
<thraxisp> The filters part is unchanged from before.
<thraxisp> Should there be an exception list of pages that don't return to the referrer when the project is changed?
<Victor> what happens if the user doesn't have access to the same page on the new project?
<thraxisp> The page will give an access denied, and you'll go to the mailpage for the project.
<thraxisp> ^mail^main
<Victor> ok
<Victor> sounds good then.
<thraxisp> I'll test the changes and submit it.
<Victor> ok. |
