View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0034618 | mantisbt | administration | public | 2024-09-05 16:27 | 2024-09-28 11:28 |
Reporter | atrol | Assigned To | dregad | ||
Priority | normal | Severity | major | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | 2.26.3 | ||||
Target Version | 2.26.4 | Fixed in Version | 2.26.4 | ||
Summary | 0034618: Disabled projects are not listed on page manage_proj_page.php | ||||
Description | Regression introduced in 2.26.3 when implementing 0034526 Initially reported in the forums https://mantisbt.org/forums/viewtopic.php?p=79584 | ||||
Tags | No tags attached. | ||||
@aaribaud-fgs @dregad would be good if you could have a look at this. |
|
Bug confirmed. I'll have a look. |
|
Proposed fix https://github.com/mantisbt/mantisbt/pull/2027 Testing and feedback welcome. |
|
@atrol I noticed you targeted 2.26.4 for this fix. With 2.27 just around the corner, I was not actually planning on releasing another hotfix for 2.26 branch - IMO it's not worth the effort.. Would you agree to change target version to 2.27.0 ? |
|
@dregad in my professional environment, the anser would be "no", as I don't like telling customers to upgrade to a fresh x.x.0 release to fix a major regression. |
|
Good afternoon, everyone. I reported the issue in the forum and, yesterday, applied the proposed fix from note 0069163 by changing the necessary lines in core/project_hierarchy_api.php. The previously disabled projects are now visible again. Although I couldn't test the performance under heavy loads since our projects don’t have any subprojects, it is working as expected. Thank you very much for taking the time to verify and fix the issue. |
|
Thanks for the feedback @evanegas.solinfo |
|
MantisBT: master-2.26 0c73e36e 2024-09-06 18:00 Details Diff |
Fix disabled projets' inclusion in hierarchy cache The logic to check $p_show_disabled using is_null() was incorrect, causing disabled projects to be excluded from the cache when the param's value true. This resulted in disabled project not being listed on Manage Projects Page. Changing code to perform a boolean test fixes the problem. Regression introduced by 5ff35d16e85c1aa58cc80fea260cd0f3cfc39910 (issue 0034526). Fixes 0034618 |
Affected Issues 0034526, 0034618, 0034768 |
|
mod - core/project_hierarchy_api.php | Diff File |