View Issue Details

IDProjectCategoryView StatusLast Update
0034618mantisbtadministrationpublic2024-09-28 11:28
Reporteratrol Assigned Todregad  
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Product Version2.26.3 
Target Version2.26.4Fixed in Version2.26.4 
Summary0034618: Disabled projects are not listed on page manage_proj_page.php
Description

Regression introduced in 2.26.3 when implementing 0034526

Initially reported in the forums https://mantisbt.org/forums/viewtopic.php?p=79584

TagsNo tags attached.

Relationships

related to 0034526 closedcommunity Bad performance when editing a project having a lot of subprojects 
related to 0034768 closedatrol 'INTERNAL APPLICATION ERROR' editing some projects from manage_proj_page.php 

Activities

atrol

atrol

2024-09-05 16:32

developer   ~0069160

Last edited: 2024-09-05 16:36

@aaribaud-fgs @dregad would be good if you could have a look at this.
I don't have time to have a deeper look, but I am asking myself if the new is_null checks are right. E. g. isn't !is_null( $p_show_disabled ) always true?

dregad

dregad

2024-09-06 11:32

developer   ~0069162

Bug confirmed. I'll have a look.

dregad

dregad

2024-09-06 18:54

developer   ~0069163

Proposed fix https://github.com/mantisbt/mantisbt/pull/2027

Testing and feedback welcome.

dregad

dregad

2024-09-09 06:01

developer   ~0069178

@atrol I noticed you targeted 2.26.4 for this fix. With 2.27 just around the corner, I was not actually planning on releasing another hotfix for 2.26 branch - IMO it's not worth the effort.. Would you agree to change target version to 2.27.0 ?

atrol

atrol

2024-09-09 07:45

developer   ~0069179

Would you agree to change target version to 2.27.0 ?

@dregad in my professional environment, the anser would be "no", as I don't like telling customers to upgrade to a fresh x.x.0 release to fix a major regression.
In your / our situation, the answer is "yes", due the little spare time we can invest.
If more users should ask (issue was triggered in forum), we could provide manual instructions how to fix it.

evanegas.solinfo

evanegas.solinfo

2024-09-13 16:42

reporter   ~0069219

Good afternoon, everyone.

I reported the issue in the forum and, yesterday, applied the proposed fix from note 0069163 by changing the necessary lines in core/project_hierarchy_api.php. The previously disabled projects are now visible again. Although I couldn't test the performance under heavy loads since our projects don’t have any subprojects, it is working as expected. Thank you very much for taking the time to verify and fix the issue.

dregad

dregad

2024-09-13 19:30

developer   ~0069220

Thanks for the feedback @evanegas.solinfo

Related Changesets

MantisBT: master-2.26 0c73e36e

2024-09-06 18:00

dregad


Details Diff
Fix disabled projets' inclusion in hierarchy cache

The logic to check $p_show_disabled using is_null() was incorrect,
causing disabled projects to be excluded from the cache when the param's
value true.

This resulted in disabled project not being listed on Manage Projects
Page. Changing code to perform a boolean test fixes the problem.

Regression introduced by 5ff35d16e85c1aa58cc80fea260cd0f3cfc39910
(issue 0034526).

Fixes 0034618
Affected Issues
0034526, 0034618, 0034768
mod - core/project_hierarchy_api.php Diff File