Source Control Integration

master-1.3.x 7b06ee38 2019-06-05 00:59 dregad Details Diff	Fix mc_project_version_update() return value The function's return type does not match the WSDL definition. This is a regression introduced by a80f447687722b52160d00c96c21a5be5f4329e1 which changed version_update()'s return type from true (bool) to void Since mc_project_version_update() actually returned that, it causes a side effect because void == NULL == false. To avoid an unnecessary and potentially breaking change in the WSDL, the function now returns true. Fixes 0025856 (cherry picked from commit a309d0ab758bec99bc42643981545e730b3f6a81)	Affected Issues 0025856
	mod - api/soap/mc_project_api.php	Diff File
master a309d0ab 2019-06-05 00:59 dregad Details Diff	Fix mc_project_version_update() return value The function's return type does not match the WSDL definition. This is a regression introduced by a80f447687722b52160d00c96c21a5be5f4329e1 which changed version_update()'s return type from true (bool) to void Since mc_project_version_update() actually returned that, it causes a side effect because void == NULL == false. To avoid an unnecessary and potentially breaking change in the WSDL, the function now returns true. Fixes 0025470	Affected Issues 0025470
	mod - api/soap/mc_project_api.php	Diff File
master 3536f696 2019-06-03 07:38 translatewiki.net Details Diff	Localisation updates from https://translatewiki.net.
	mod - lang/strings_belarusian_tarask.txt	Diff File
	mod - lang/strings_chinese_traditional.txt	Diff File
	mod - lang/strings_french.txt	Diff File
	mod - lang/strings_hebrew.txt	Diff File
	mod - lang/strings_hungarian.txt	Diff File
	mod - plugins/MantisCoreFormatting/lang/strings_eo.txt	Diff File
	mod - plugins/XmlImportExport/lang/strings_eo.txt	Diff File
master b90cc957 2019-06-02 23:23 vboctor Details Diff	Use standard REST issue + issue view extra info	Affected Issues 0026125, 0026600
	mod - bug_view_inc.php	Diff File
	mod - core/commands/IssueViewCommand.php	Diff File
master 6236a653 2019-06-02 20:57 vboctor Details Diff	Merge history_inc.php into bug_view_inc.php
	mod - bug_view_inc.php	Diff File
	rm - history_inc.php	Diff
master 2b163046 2019-06-02 20:50 vboctor Details Diff	Add IssueViewCommand and use it in bug_view_inc.php	Affected Issues 0025902, 0029181
	mod - bug_view_inc.php	Diff File
	add - core/commands/IssueViewCommand.php	Diff File
master 9c66d394 2019-06-02 06:05 dregad Details Diff	Revert maintenance mode in TestConfig.php For an unknown reason, commit 59970d8735dd06975c3aeabbd9ce8ba0d7593b16 (part of issue 0020837) set MANTIS_MAINTENANCE_MODE. As a consequence, it is not possible to use any database function as as part of unit tests. Since the tests added in the above-mentioned commit are also successful without maintenance mode, it makes sense to revert this change.	Affected Issues 0020837
	mod - tests/TestConfig.php	Diff File
master 8f9c386d 2019-05-31 14:50 dregad Details Diff	Merge remote-tracking branch 'cproensa/0025742_summary_by_date_add'
	mod - core/summary_api.php	Diff File
master afb40dca 2019-05-31 13:20 dregad Details Diff	Improve Admin Guide/PHPDoc for monitors thresholds Add recommendation to set $g_monitor_add_others_bug_threshold and $g_monitor_delete_others_bug_threshold to a value not be lower than $g_show_monitor_list_threshold. Add missing entry for $g_show_monitor_list_threshold in Misc config section. Fixes 0025827	Affected Issues 0025827
	mod - config_defaults_inc.php	Diff File
	mod - docbook/Admin_Guide/en-US/config/misc.xml	Diff File
master 83dae420 2019-05-31 13:19 dregad Details Diff	Reorder declaration of $g_show_monitor_list_threshold Regroup it with other monitors-related configs. Fixes 0025827	Affected Issues 0025827
	mod - config_defaults_inc.php	Diff File
master 1a730577 2019-05-31 13:00 dregad Details Diff	Add missing configs in manage workflow thresholds The add/remove monitors thresholds (monitor_add_others_bug_threshold, monitor_add_others_bug_threshold) were not configurable via manage_config_work_threshold_page.php Fixes 0025826	Affected Issues 0025826
	mod - docbook/Admin_Guide/en-US/Page_Descriptions.xml	Diff File
	mod - lang/strings_english.txt	Diff File
	mod - manage_config_work_threshold_page.php	Diff File
	mod - manage_config_work_threshold_set.php	Diff File
master 1ef47af5 2019-05-30 08:52 dregad Details Diff	Remove extra space in <a> tag
	mod - core/prepare_api.php	Diff File
master e5a8ca4a 2019-05-30 08:50 dregad Details Diff	Let users add monitors even if they can't see them In view.php, the 'Users monitoring this issue' box is only displayed if the user has $g_show_monitor_list_threshold. If the same user had $g_monitor_add_others_bug_threshold, they would not be able to adding new monitors. This is an uncommon situation, as monitor_add_others_bug_threshold is expected to be >= show_monitor_list_threshold. Still it makes sense to fix that since the configuration allows such setup. With this change, an 'Access Denied' message is displayed instead of the users' list if access level is below show_monitor_list_threshold and >= monitor_add_others_bug_threshold, and the form to add new monitors is shown. If user's access level is lower than both thresholds, then the behavior is unchanged, i.e. the whole box is hidden. Fixes 0025815	Affected Issues 0025815
	mod - bug_monitor_list_view_inc.php	Diff File
master-2.21 5bade1d5 2019-05-30 02:04 cproensa Committer: dregad Details Diff	Fix mssql summary error When computing SUM & AVG functions, sqlserver uses the column datatype, which is INT. This datatype can be overflowed when a big number of issues are included, since we are adding the total number of seconds. In that case, use an explicit cast to BIGINT to avoid that error. Other databases are not affected because they use a runtime data type allowing bigger integers. The stats array is initialized to zero, to return a properly formatted value array when there aren't any issues. Fixes 0025781 PR https://github.com/mantisbt/mantisbt/pull/1516	Affected Issues 0025781
	mod - core/summary_api.php	Diff File
master 49539f33 2019-05-30 02:04 cproensa Committer: dregad Details Diff	Fix mssql summary error When computing SUM & AVG functions, sqlserver uses the column datatype, which is INT. This datatype can be overflowed when a big number of issues are included, since we are adding the total number of seconds. In that case, use an explicit cast to BIGINT to avoid that error. Other databases are not affected because they use a runtime data type allowing bigger integers. The stats array is initialized to zero, to return a properly formatted value array when there aren't any issues. Fixes 0025781 PR https://github.com/mantisbt/mantisbt/pull/1516	Affected Issues 0025781
	mod - core/summary_api.php	Diff File
master f1191b68 2019-05-27 06:46 translatewiki.net Details Diff	Localisation updates from https://translatewiki.net.
	mod - lang/strings_eo.txt	Diff File
	mod - lang/strings_persian.txt	Diff File
	mod - lang/strings_ukrainian.txt	Diff File
	mod - plugins/MantisCoreFormatting/lang/strings_eo.txt	Diff File
	mod - plugins/MantisGraph/lang/strings_ukrainian.txt	Diff File
	mod - plugins/XmlImportExport/lang/strings_eo.txt	Diff File
master 54e553d5 2019-05-23 15:35 dregad Details Diff	Merge branch 'master-2.21'
	mod - manage_config_workflow_page.php	Diff File
master 53944710 2019-05-23 12:27 dregad Details Diff	Use <button> instead of <input type="submit"> For consistency, following fix for issue 0025784.	Affected Issues 0025784
	mod - manage_config_workflow_page.php	Diff File
master 3667d0cf 2019-05-23 12:23 dregad Details Diff	Fix invalid HTML in manage_config_workflow_page The generated markup has a form to revert the configuration changes defined within the main form. This is invalid HTML. To fix this without complicating the layout, we use a deported <button> within the main form, using the HTML5 `form` attribute pointing to the the revert form's id, which is defined outside. Fixes 0025784	Affected Issues 0025784
	mod - manage_config_workflow_page.php	Diff File
master-2.21 654948d0 2019-05-23 12:15 dregad Details Diff	Add missing quote causing truncated button label This bug was fixed in 1.3.0 (see issue 0020241), but was reintroduced in 2.0 during the migration to Modern UI because of an incorrect merge conflict resolution (commit 6d91468100a308a6f57f12d4c7ab3f3486aa0eee). Fixes 0025783	Affected Issues 0020241, 0025783
	mod - manage_config_workflow_page.php	Diff File
master 98cd67b8 2019-05-23 04:24 translatewiki.net Details Diff	Localisation updates from https://translatewiki.net.
	mod - lang/strings_persian.txt	Diff File
master 0249f396 2019-05-20 03:56 translatewiki.net Details Diff	Localisation updates from https://translatewiki.net.
	mod - lang/strings_eo.txt	Diff File
	mod - lang/strings_persian.txt	Diff File
	mod - plugins/MantisGraph/lang/strings_eo.txt	Diff File
i6128-new-issue-add-monitors e58c20fe 2019-05-19 09:29 dregad Details Diff	Doc: remove reference to $g_to_email config This variable was obsoleted in 0.19.0, it does not make sense anymore to use it as reference in the customizing Email Notifications section.
	mod - docbook/Admin_Guide/en-US/Customizing.xml	Diff File
master e5da1a4c 2019-05-19 09:25 dregad Details Diff	Improve PHPDoc for notify_flags Define $g_notify_flags as a single array instead of 2 distinct assignments.
	mod - config_defaults_inc.php	Diff File
i6128-new-issue-add-monitors a10930d7 2019-05-19 09:25 dregad Details Diff	Improve PHPDoc for notify_flags Define $g_notify_flags as a single array instead of 2 distinct assignments.
	mod - config_defaults_inc.php	Diff File

Changesets: MantisBT